Module:Check for unknown parameters: Difference between revisions

various changes: add a trim function, remove unnecessary parens, don't check type for wikitext values (they are always strings), and don't use mw.ustring when the string library will do (it's a lot faster)
(fix substitution of "_VALUE_" when it isn't followed by a space)
(various changes: add a trim function, remove unnecessary parens, don't check type for wikitext values (they are always strings), and don't use mw.ustring when the string library will do (it's a lot faster))
Line 3:
-- not on the list
local p = {}
 
local function trim(s)
return s:match('^%s*(.-)%s*$')
end
 
local function isnotempty(s)
return s and s:match( '^%s*trim(.-)%s*$' ) ~= ''
end
 
Line 24 ⟶ 28:
for k, v in pairs(args) do
if type(k) == 'number' then
v = mw.ustring.gsubtrim(v, '^%s*(.-)%s*$', '%1')
knownargs[v] = 1
ifelseif (k == 'unknown' and type(v) == 'string') then
else
unknown = v
if (k == 'unknown' and type(v) == 'string') then
elseif k:find('^regexp[1-9][0-9]*$') then
unknown = v
elseif (mw.ustringtable.matchinsert(kregexps, '^regexp[%d]*$') and.. type(v) ==.. 'string$') then
table.insert(regexps, '^' .. v .. '$')
end
end
end
 
-- adds one result to the output tables
local function addresult(k)
if k == '' then
Line 41 ⟶ 44:
k = ' '
end
local r = mw.ustring.unknown:gsub(unknown, '_VALUE_', k)
table.insert(res, r)
table.insert(comments, '"' .. k .. '"')
Line 47 ⟶ 50:
 
-- loop over the parent args, and make sure they are on the list
for k, v in pairs(pargs) do
if (type(k) == 'string' and knownargs[k] == nil) then
local knownflag = nilfalse
for ri, =regexp 1,#in ipairs(regexps) do
if( mw.ustring.match(k,regexps[r]) regexp) then
knownflag = 1true
break
end
end
if( (not knownflag) and ( (not ignoreblank) or (ignoreblank and isnotempty(v)) ) ) then
k = mw.ustring.gsub(k, '[^%w\-_ ]', '?')
addresult(k)
end
elseif( checkpos and type(k) == 'number' and knownargs[tostring(k)] == nil) then
type(k) == 'number' and
if( (not ignoreblank) or (ignoreblank and isnotempty(v)) ) then
knownargs[tostring(k)] == nil and
addresult(k)
if( (not ignoreblank) or (ignoreblank and isnotempty(v)) ) then
end
then
addresult(k)
end
end
 
if( #comments > 0) then
commentstr = '<!-- Module:Check for unknown parameters results: ' ..
table.concat(comments, ', ') .. '-->'